Skip to content

Conversation

@vinitpayal
Copy link
Contributor

@vinitpayal vinitpayal commented Aug 9, 2022

This pull request adds a new sensor for Google Cloud Tasks to sense cloud task queue being empty


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@vinitpayal vinitpayal requested a review from turbaszek as a code owner August 9, 2022 15:32
@boring-cyborg boring-cyborg bot added area:providers provider:google Google (including GCP) related issues labels Aug 9, 2022
@potiuk
Copy link
Member

potiuk commented Aug 9, 2022

Needs doc update, provider update, examples.

- Fix the existing documentation for cloud tasks
@vinitpayal vinitpayal requested a review from mik-laj as a code owner August 10, 2022 05:30
@ghost
Copy link

ghost commented Aug 10, 2022

Sorry wasn't aware of the process for adding documentation & added it now.

@mik-laj @potiuk let me know if made any mistakes in documenting addition as the format was a bit new to me. Otherwise, I think the PR is ready to be merged now.

@vinitpayal
Copy link
Contributor Author

@potiuk please let me know if need any other help in getting it merged?

vinitpayal and others added 3 commits August 20, 2022 16:57
Co-authored-by: Pankaj Singh <98807258+pankajastro@users.noreply.github.com>
Co-authored-by: Pankaj Singh <98807258+pankajastro@users.noreply.github.com>
Co-authored-by: Pankaj Singh <98807258+pankajastro@users.noreply.github.com>
vinitpayal and others added 2 commits August 20, 2022 16:58
Co-authored-by: Pankaj Singh <98807258+pankajastro@users.noreply.github.com>
@vinitpayal
Copy link
Contributor Author

Thanks @pankajastro, suggestions well noted and applied.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:providers provider:google Google (including GCP) related issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants