Only excluded actually expanded fields from render #25599
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Seems to make sense. |
Previously we excluded all mapped kwargs from being rendered, which cause issues for fields that are not actually rendered during expansion (i.e. those that are literals). This new implementation adds some extra logic to ensure we still include kwargs that still need rendering.
uranusjr
force-pushed
the
unmap-render-none-xcomarg-field
branch
from
ad73089 to
317a93b
Compare
ephraimbuddy
approved these changes
Aug 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we excluded all mapped kwargs from being rendered, which cause issues for fields that are not actually rendered during expansion (i.e. those that are literals). This new implementation adds some extra logic to ensure we still include kwargs that still need rendering.
Fix #25588.