Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use newer kubernetes authentication method in internal vault client #25351

Merged
merged 1 commit into from
Jul 28, 2022

Conversation

pdebelak
Copy link
Contributor

This gets rid of the hvac deprecation warning about auth_kubernetes being removed in version 1.0 that is currently printed when using this authentication method.

closes: #25349

This gets rid of the hvac deprecation warning about `auth_kubernetes`
being removed in version 1.0 that is currently printed when using this
authentication method.
@boring-cyborg
Copy link

boring-cyborg bot commented Jul 27, 2022

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:

  • Pay attention to the quality of your code (flake8, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

@potiuk
Copy link
Member

potiuk commented Jul 28, 2022

Nice one :)

@potiuk potiuk merged commit ad0a496 into apache:main Jul 28, 2022
@boring-cyborg
Copy link

boring-cyborg bot commented Jul 28, 2022

Awesome work, congrats on your first merged pull request!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Vault client for hashicorp provider prints a deprecation warning when using kubernetes login
2 participants