Deprecate hql parameters and synchronize DBApiHook method APIs #25299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:providers
provider:Apache
provider:google
|
This also simplifies and removes some MyPy Hacks with "overloads" :) |
uranusjr
reviewed
Jul 26, 2022
potiuk
force-pushed
the
synchronize-signatures-between-dbapi-hooks
branch
from
d7f4831
to
d9dffc8
Compare
uranusjr
reviewed
Jul 26, 2022
potiuk
force-pushed
the
synchronize-signatures-between-dbapi-hooks
branch
from
d9dffc8
to
83c6726
Compare
potiuk
force-pushed
the
synchronize-signatures-between-dbapi-hooks
branch
from
83c6726
to
fd331e0
Compare
potiuk
force-pushed
the
synchronize-signatures-between-dbapi-hooks
branch
3 times, most recently
from
7b851fc
to
b2a3329
Compare
kazanzhy
reviewed
Jul 26, 2022
kazanzhy
reviewed
Jul 26, 2022
kazanzhy
reviewed
Jul 26, 2022
kazanzhy
reviewed
Jul 26, 2022
kazanzhy
reviewed
Jul 26, 2022
kazanzhy
reviewed
Jul 26, 2022
kazanzhy
reviewed
Jul 26, 2022
kazanzhy
reviewed
Jul 26, 2022
kazanzhy
reviewed
Jul 26, 2022
potiuk
force-pushed
the
synchronize-signatures-between-dbapi-hooks
branch
from
b2a3329
to
3d23031
Compare
|
All parameters updated @kazanzhy :) |
potiuk
force-pushed
the
synchronize-signatures-between-dbapi-hooks
branch
2 times, most recently
from
8567e08
to
40c94f9
Compare
|
Should be green now. |
Various providers deriving from DbApi had some variations in some methods that were derived from the common DbApi Hook. Mostly they were about extra parameters added and hql parameter used instead of sql. This prevents from really "common" approach in DbApiHook as some common sql operators rely on signatures being the same. This introduced breaking changes in a few providers - but those breaking changes are easy to fix and most have already been deprecated.
potiuk
force-pushed
the
synchronize-signatures-between-dbapi-hooks
branch
from
40c94f9
to
7a98394
Compare
|
Should be merged after #25338 (this PR incorporates change that should be separated). |
|
(now it should be green :) ) |
|
Green :) |
potiuk
commented
Jul 27, 2022
| @@ -143,7 +143,7 @@ function testing::setup_docker_compose_backend() { | |||
| # so we need to mount an external volume for its db location | |||
| # the external db must allow for parallel testing so TEST_TYPE | |||
| # is added to the volume name | |||
| export MSSQL_DATA_VOLUME="${HOME}/tmp-mssql-volume-${TEST_TYPE}-${MSSQL_VERSION}" | |||
| export MSSQL_DATA_VOLUME="${HOME}/tmp-mssql-volume-${TEST_TYPE/\[*\]/}-${MSSQL_VERSION}" | |||
There was a problem hiding this comment.
This is already merged in main via #25338
eladkal
reviewed
Jul 27, 2022
Co-authored-by: eladkal <45845474+eladkal@users.noreply.github.com>
eladkal
approved these changes
Jul 27, 2022
|
Woohooo! |
This was referenced Aug 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Various providers deriving from DbApi had some variations in some
methods that were derived from the common DbApi Hook. Mostly they
were about extra parameters added and hql parameter used instead of
sql. This prevents from really "common" approach in DbApiHook as
some common sql operators rely on signatures being the same.
This introduced breaking changes in a few providers - but those
breaking changes are easy to fix and most have already been
deprecated.
I also had to make sure all types are correct (hence cloud_sql typing fixes).
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.