Fix xcom_sidecar stuck problem #24993
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
provider:cncf-kubernetes
uranusjr
reviewed
Jul 12, 2022
| @@ -404,8 +404,12 @@ def await_pod_start(self, pod: k8s.V1Pod): | |||
| def extract_xcom(self, pod: k8s.V1Pod): | |||
| """Retrieves xcom value and kills xcom sidecar container""" | |||
| result = self.pod_manager.extract_xcom(pod) | |||
| self.log.info("xcom result: \n%s", result) | |||
| return json.loads(result) | |||
| if isinstance(result, str) and result.replace('\n', '') == 'False': | |||
There was a problem hiding this comment.
Suggested change
| if isinstance(result, str) and result.replace('\n', '') == 'False': | |
| if isinstance(result, str) and result.rstrip() == 'False': |
It may also be worthwile to use a more obscure string (say __airflow_xcom_result_empty__?) to make the intent easier to identify.
potiuk
approved these changes
Jul 16, 2022
This was referenced Aug 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the problem which is described here #22318
closes: #22318
Co-authored-by: Wojciech Januszek januszek@google.com
Co-authored-by: Lukasz Wyszomirski wyszomirski@google.com
Co-authored-by: Maksim Yermakou maksimy@google.com
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.