Move provider dependencies to inside provider folders#24671
Closed
potiuk wants to merge 1 commit intoapache:mainfrom
Closed
Move provider dependencies to inside provider folders#24671potiuk wants to merge 1 commit intoapache:mainfrom
potiuk wants to merge 1 commit intoapache:mainfrom
Conversation
potiuk
commented
Jun 27, 2022
The ``setup.py`` had ALWAUS contained provider dependencies, but this is really a remnant of Airlfow 1.10 where providers were not separated out to subfolders of "providers". This change moves all the provider-specific dependencies to provider.yaml where they are kept together with all other provider meta-data. Later, when we move providers out, we can move them to provider specific setup.py files (or let provider-specific setup.py files read them from provider.yaml) but this is not something we want to do it now. The dependencies.json is now renamed to provider_dependencies.json and moved to "airflow" so tha it can be kept as part of the sources needed for sdist package to provide extras. Pre-commit still generates the file as needed and it contains now both: * cross-provider-deps information which providers depend on each other * deps - information what regular dependencies are needed for each provider On top of preparing to splitting providers it has the advantage, that there will be no more case where adding a dependency change for provider will not run tests for that provider.
99ddc72 to
83d1b99
Compare
Member
Author
|
Closing this one i favour of #24672 - this one is run from "apache" repo, so we will be able to see production build succeeding (from fork it will fail until it is merged). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
setup.pyhad ALWAUS contained provider dependencies,but this is really a remnant of Airlfow 1.10 where providers
were not separated out to subfolders of "providers".
This change moves all the provider-specific dependencies
to provider.yaml where they are kept together with all other
provider meta-data.
Later, when we move providers out, we can move them to
provider specific setup.py files (or let provider-specific
setup.py files read them from provider.yaml) but this is
not something we want to do it now.
The dependencies.json is now renamed to provider_dependencies.json
and moved to "airflow" so tha it can be kept as part of the
sources needed for sdist package to provide extras. Pre-commit still
generates the file as needed and it contains now both:
other
provider
On top of preparing to splitting providers it has the advantage,
that there will be no more case where adding a dependency change
for provider will not run tests for that provider.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragement file, named
{pr_number}.significant.rst, in newsfragments.