Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unify DbApiHook.run() method with the methods which override it #23971
Unify DbApiHook.run() method with the methods which override it #23971
Changes from all commits
f614f47
368420c
a184b34
f9e1461
6fd8745
dcc2deb
c3cdcd0
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is backwards-incompatike. Currently when run gets a single SQL string, it return s single result, if it gets array of strings it returns array of results. In order to keep backwards compatibility we should retain this behaviour.
I think the reasonable approach will be to check if even after split we have one or multiple queries. If 1 -> return resullts[0] else results.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmm. I see that there are different behaviours in different operators. I think for now maybe we need another parameter (scalar_single_result: bool) ? this way we could keep full backwards compatibility in all the providers I think ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think in the very first iteration it was
return results[-1]
which good for a single statement and list of them.In one of our previous PRs, we got the idea to return all statement's results.
#23623 (comment)
In this case, we will have the next returning type
Optional[List[HandlerResult]]
.Before that, it was
Optional[HandlerResult]
. We could add parameterreturn_last=True
and then we will haveOptional[Union[HandlerResult, List[HandlerResult]]]
.For example:
-> None
else:return_last=True
then-> HandlerResult
split_statements=True
andreturn_last=True
then-> HandlerResult
split_statements=True
andreturn_last=False
then-> List[HandlerResult]
also for one statement we could return a list with single value
if one statement and
return_last=False
then-> List[HandlerResult]
In code, I assume it'll be
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
return_last
flag seems reasonable.I do like to point to my note #23623 (comment) but that ship has sailed.