UI page title to allow for Markup #20888
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PApostol
requested review from
ashb,
bbovenzi,
kaxil,
potiuk and
ryanahamilton
as code owners
boring-cyborg
bot
added
area:webserver
Contributor
|
Nice change! lgtm |
Member
|
Hmmm for some reason this sits a little uneasily with me, but I can't actually think of any way it would go wrong (in an exploitable way) |
Contributor
Author
I understand where you're coming from, but essentially it's not too different from the UIAlert code (that's where I got the idea from). |
kaxil
reviewed
Jan 18, 2022
kaxil
approved these changes
Jan 19, 2022
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set
instance_name_has_markup = Trueinairflow.cfgto renderinstance_namewith Markup.Closes #20877.