AwsAthenaOperator: do not generate client_request_token if not provided #20854
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- According to AWS doc (link provided below), boto3 will autopopulated ClientRequestToken is not provided. So it's not necessary to generate it explicitly here - The current logic means a UUID will be generated when the DAG is being parsed into a DAG object. When we check this DAG object, we will see a "random" client_request_token This may not be desired (for example in the product my team is running, this is causing issue). AWS Doc link: https://boto3.amazonaws.com/v1/documentation/api/1.18.0/reference/services/athena.html?highlight=start_query_execution#Athena.Client.start_query_execution
boring-cyborg
bot
added
area:providers
provider:amazon-aws
kaxil
approved these changes
Jan 13, 2022
This was referenced Feb 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to remove an unnecessary logic in
AwsAthenaOperator(and in certain use cases, it may cause confusion)What this PR does
For
AwsAthenaOperator, ifclient_request_tokenis not provided, we should do nothing here, rather than generating a UUID explicitly for it.Why do we need this change
ClientRequestTokenif it's not provided. So it's not necessary to generate it explicitly hereclient_request_token. This may not be desired (for example in the product my team is running, this is causing issue).Reference
Relevant AWS Doc link: https://boto3.amazonaws.com/v1/documentation/api/1.18.0/reference/services/athena.html?highlight=start_query_execution#Athena.Client.start_query_execution