Fix mypy typing for airflow/models and their tests

[ashb]

The re-ordering of setting attributes in BaseOperator is because
something about that function (throwing the exceptions?) causes mypy
to think that BaseOperator objects could be missing those attributes

Part of #19891

---

^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.

[potiuk]

Few nits and questions

[github-actions]

The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.

[potiuk]

Few statics to fix too.

[ashb]

Few statics to fix too.

Yeah, flake8 was having odd problems and not running for me locally last night (wasn't giving any errors, but just saying it failed. I didn't dig in to it closely as it was late)

[potiuk]

LGTM!

[ashb]

For reference this is the flake8 error I get:

Run flake8...............................................................................Failed
- hook id: flake8
- exit code: 1

No need to pull the image. Yours and remote cache hashes are the same!

cat: /home/ash/code/airflow/airflow/manifests/remote-airflow-manifest-image-3.7: No such file or directory
must specify at least one container source

ERROR: The previous step completed with error. Please take a look at output above 

cat: /home/ash/code/airflow/airflow/manifests/remote-airflow-manifest-image-3.7: No such file or directory
Container name cannot be empty

ERROR: The previous step completed with error. Please take a look at output above 

Container ID file found, make sure the other container isn't running or delete /home/ash/code/airflow/airflow/manifests/remote-airflow-manifest-image-3.7

ERROR: The previous step completed with error. Please take a look at output above 


No need to pull the image. Yours and remote cache hashes are the same!

Container ID file found, make sure the other container isn't running or delete /home/ash/code/airflow/airflow/manifests/remote-airflow-manifest-image-3.7

ERROR: The previous step completed with error. Please take a look at output above 

Container ID file found, make sure the other container isn't running or delete /home/ash/code/airflow/airflow/manifests/remote-airflow-manifest-image-3.7

ERROR: The previous step completed with error. Please take a look at output above 

Container name cannot be empty

[ashb]

MyPy now not reporting anything for models/ buut it looks like MSSQL might be unhapy.

Fix one break one 😞

[potiuk]

Container name cannot be empty

breeze build-image --python 3.7 should fix it - but I will see why it fails in the absence of manifest.

[potiuk]

Hey @ashb - the cat: /home/ash/code/airflow/airflow/manifests/remote-airflow-manifest-image-3.7: No such file or directory might be a side effect of expired GITHUB_TOKEN . Can you please double check this ?

Unfortunately (I raised it to github) if you have expired token, you even can't download public images (!) which you can when you have no GITHUB_TOKEN at all!

[potiuk]

If that's confirmed I might want to add some protection agains that :)

[ashb]

I have no GITHUB_TOKEN in the env, and /home/ash/code/airflow/airflow/manifests does exist and contains a few files.

[ashb]

Ah -- but I do have ghcr.io in my ~/.docker/config.json -- let me try removing that

[ashb]

No dice.

$ docker logout ghcr.io
...
$ git commit
...
Run flake8...............................................................................Failed
- hook id: flake8
- exit code: 1

cat: /home/ash/code/airflow/airflow/manifests/remote-airflow-manifest-image-3.7: No such file or directory
must specify at least one container source

ERROR: The previous step completed with error. Please take a look at output above 

[ashb]

non-verbose and verbose output of running flake8 here @potiuk https://gist.github.com/ashb/791aa5b98d12942fd871fa4291bb6346

[potiuk]

AaaaaaH I know! Flake checks run in parallell and remove each other generated file !

[potiuk]

Fix here @ashb #20294