Chart: rename kerberos-keytab secret file #20064
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aakcht
requested review from
ashb,
dimberman,
jedcunningham and
kaxil
as code owners
Aakcht
force-pushed
the
chart_keytab_secret_rename
branch
from
e4002e8 to
adb44da
Compare
|
Looks like the not successful check is not related to this PR, I can retrigger it if needed. |
potiuk
approved these changes
Dec 6, 2021
|
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease. |
github-actions
bot
added
the
okay to merge
|
I think even if it "was" released, we could change it still. That's the beauty of helm chart that it packages things nicely and thins like file names are really implementation detail not public API. |
jedcunningham
added
the
changelog:skip
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A minor inconsistency I noticed in #19054 - all the filenames in https://github.com/apache/airflow/tree/main/chart/templates/secrets end with
-secretexcept for the keytab secret I added in #19054 . Since #19054 hasn't been released, maybe it's not too late to rename the file?^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.