Skip to content

Patch utcnow in retry delay test #18343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 1, 2021
Merged

Patch utcnow in retry delay test #18343

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d242370
Remove sleep from retry delay test
edwardwang888 Sep 18, 2021
78f06b6
Change to use freezegun
edwardwang888 Sep 19, 2021
9dc4227
Approximate smallest timedelta without numpy
edwardwang888 Sep 19, 2021
64b7228
Use pre-defined smallest timedelta
edwardwang888 Sep 20, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions tests/models/test_taskinstance.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@
import datetime
import os
import signal
import time
import urllib
from tempfile import NamedTemporaryFile
from typing import List, Optional, Union, cast
Expand Down Expand Up @@ -489,7 +488,8 @@ def test_task_retry_wipes_next_fields(self, session, dag_maker):
assert ti.next_kwargs is None
assert ti.state == State.UP_FOR_RETRY

def test_retry_delay(self, dag_maker):
@freeze_time('2021-09-19 04:56:35', as_kwarg='frozen_time')
def test_retry_delay(self, dag_maker, frozen_time=None):
"""
Test that retry delays are respected
"""
Expand Down Expand Up @@ -517,11 +517,12 @@ def run_with_error(ti):
assert ti.try_number == 2

# second run -- still up for retry because retry_delay hasn't expired
frozen_time.tick(delta=datetime.timedelta(seconds=3))
run_with_error(ti)
assert ti.state == State.UP_FOR_RETRY

# third run -- failed
time.sleep(3)
frozen_time.tick(delta=datetime.datetime.resolution)
run_with_error(ti)
assert ti.state == State.FAILED

Expand Down