Skip to content

Bug fix for ExternalTaskSensor with failed_states, allowed_states, and execution_date_fn set #16205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
eitanme wants to merge 1 commit into from
Closed

Bug fix for ExternalTaskSensor with failed_states, allowed_states, and execution_date_fn set #16205

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 8 additions & 7 deletions airflow/sensors/external_task.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,13 +162,14 @@ def poke(self, context, session=None):
if self.failed_states:
count_failed = self.get_count(dttm_filter, session, self.failed_states)

if count_failed == len(dttm_filter):
if self.external_task_id:
raise AirflowException(
f'The external task {self.external_task_id} in DAG {self.external_dag_id} failed.'
)
else:
raise AirflowException(f'The external DAG {self.external_dag_id} failed.')
# Fail if anything in the list has failed.
if count_failed > 0:
if self.external_task_id:
raise AirflowException(
f'The external task {self.external_task_id} in DAG {self.external_dag_id} failed.'
)
else:
raise AirflowException(f'The external DAG {self.external_dag_id} failed.')

return count_allowed == len(dttm_filter)

Expand Down