Skip to content

Further fix trimmed pod_id for KubernetesPodOperator #15445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 20, 2021

Conversation

kaxil
Copy link
Member

@kaxil kaxil commented Apr 20, 2021

Missed a case in (#15443) where . can be followed by another ..


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.

Missed a case in (apache#15443) where `.` can be followed by another `.`.
@kaxil kaxil added this to the Airflow 2.0.3 milestone Apr 20, 2021
@kaxil kaxil requested review from houqp and jedcunningham April 20, 2021 00:40
@kaxil kaxil requested a review from dimberman as a code owner April 20, 2021 00:40
@boring-cyborg boring-cyborg bot added the provider:cncf-kubernetes Kubernetes (k8s) provider related issues label Apr 20, 2021
@github-actions
Copy link

The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest master at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.

@github-actions github-actions bot added the full tests needed We need to run full set of tests for this PR to merge label Apr 20, 2021
@kaxil kaxil merged commit 1e66ce8 into apache:master Apr 20, 2021
@kaxil kaxil deleted the fix-pd-name branch April 20, 2021 10:23
kaxil added a commit to astronomer/airflow that referenced this pull request Apr 20, 2021
Missed a case in (apache#15443) where `.` can be followed by another `.`.

(cherry picked from commit 1e66ce8)
kaxil added a commit to astronomer/airflow that referenced this pull request Apr 26, 2021
Missed a case in (apache#15443) where `.` can be followed by another `.`.

(cherry picked from commit 1e66ce8)
@potiuk potiuk modified the milestone: Airflow 2.0.3 May 9, 2021
potiuk pushed a commit that referenced this pull request May 9, 2021
Missed a case in (#15443) where `.` can be followed by another `.`.

(cherry picked from commit 1e66ce8)
@ashb ashb modified the milestones: Airflow 2.0.3, Airflow 2.1 May 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
full tests needed We need to run full set of tests for this PR to merge provider:cncf-kubernetes Kubernetes (k8s) provider related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants