Skip to content

Migrate graph js #15307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 9, 2021
Merged

Migrate graph js #15307

merged 3 commits into from
Apr 9, 2021

Conversation

bbovenzi
Copy link
Contributor

@bbovenzi bbovenzi commented Apr 9, 2021

Part of #14115 to move most of the javascript for the graph view to its own file.

A lot of linting was fixed but some parts like iterators weren't touched for now to avoid unintentionally breaking everything.


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.

@boring-cyborg boring-cyborg bot added area:UI Related to UI/UX. For Frontend Developers. area:webserver Webserver related Issues labels Apr 9, 2021
Copy link
Contributor

@ryanahamilton ryanahamilton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I ran through some testing locally and everything appears to be working as expected.

@github-actions github-actions bot added the okay to merge It's ok to merge this PR as it does not require more tests label Apr 9, 2021
@github-actions
Copy link

github-actions bot commented Apr 9, 2021

The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest master or amend the last commit of the PR, and push it with --force-with-lease.

@ryanahamilton ryanahamilton merged commit bcc6c93 into apache:master Apr 9, 2021
@ryanahamilton ryanahamilton deleted the migrate-graph-js branch April 9, 2021 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:UI Related to UI/UX. For Frontend Developers. area:webserver Webserver related Issues okay to merge It's ok to merge this PR as it does not require more tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants