Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test to guard how DAG/Operator params work together #15075

Merged
merged 1 commit into from
Mar 30, 2021

Conversation

XD-DENG
Copy link
Member

@XD-DENG XD-DENG commented Mar 29, 2021

params feature is important to me, and I want to have it well guarded by test coverage ;-)


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.

@XD-DENG XD-DENG added changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) type:misc/internal Changelog: Misc changes that should appear in change log labels Mar 29, 2021
@XD-DENG XD-DENG requested review from ashb, kaxil, turbaszek and mik-laj March 29, 2021 19:44
@kaxil
Copy link
Member

kaxil commented Mar 29, 2021

Should be fixed after #15076 is merged and the PR is rebased on master

@github-actions
Copy link

The Workflow run is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*.

@github-actions
Copy link

The Workflow run is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*.

@github-actions
Copy link

The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest master at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.

@github-actions github-actions bot added the full tests needed We need to run full set of tests for this PR to merge label Mar 29, 2021
@XD-DENG XD-DENG force-pushed the enhance-tests-for-params branch from bf016ac to dfd6cc1 Compare March 30, 2021 06:32
@XD-DENG XD-DENG force-pushed the enhance-tests-for-params branch from dfd6cc1 to fb2688f Compare March 30, 2021 06:51
@XD-DENG XD-DENG merged commit daa3f3c into apache:master Mar 30, 2021
@XD-DENG XD-DENG deleted the enhance-tests-for-params branch March 30, 2021 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) full tests needed We need to run full set of tests for this PR to merge type:misc/internal Changelog: Misc changes that should appear in change log
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants