Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suppress LOG/WARNING for a few tasks CLI for better CLI experience #14567

Merged
merged 2 commits into from
Mar 3, 2021

Conversation

XD-DENG
Copy link
Member

@XD-DENG XD-DENG commented Mar 2, 2021

For state/list/render, more likely users would like to rely on the CLI output for some work, and the Python LOG/WARNING prints cause inconvenience, for example

Default__-zsh_


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.

For 'state'/'list'/'render', more likely users
would like to rely on the CLI output for some works,
and the Python LOG/WARNING prints cause inconvenience.
@XD-DENG XD-DENG added area:CLI type:improvement Changelog: Improvements labels Mar 2, 2021
@XD-DENG XD-DENG requested review from kaxil, turbaszek and mik-laj March 2, 2021 20:20
@XD-DENG
Copy link
Member Author

XD-DENG commented Mar 2, 2021

For milestone, I think it should be at least partially depending on #13180

@kaxil
Copy link
Member

kaxil commented Mar 2, 2021

Some tests are failing

@github-actions
Copy link

github-actions bot commented Mar 2, 2021

The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest master or amend the last commit of the PR, and push it with --force-with-lease.

@github-actions github-actions bot added the okay to merge It's ok to merge this PR as it does not require more tests label Mar 2, 2021
@XD-DENG
Copy link
Member Author

XD-DENG commented Mar 3, 2021

Thanks @kaxil .

Fixed in bbee3e7 and the CI is green now. Gonna merge.

@XD-DENG XD-DENG merged commit 9c44f81 into apache:master Mar 3, 2021
@XD-DENG XD-DENG deleted the supress-prints-tasks-commands branch March 3, 2021 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:CLI okay to merge It's ok to merge this PR as it does not require more tests type:improvement Changelog: Improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants