Use template strings for string concatenation in JS code in dags.html #13957
Conversation
- use template strings over '+' - fix bugs caused by '+' concatenation
| }) | ||
| .append('circle') | ||
| .attr('id', function(d) {return 'run-' + dag_id.replace(/\./g, '_') + d.state || 'none'}) |
There was a problem hiding this comment.
This is the bug I'm referring to.
When d.state is null or undefined, it's like:
'a-' + null || 'none'This gives us a-null, while we actually expect a-none. So this should be
'a-' + (null || 'none')But of course this is fixed if we use template string for this.
| }) | ||
| .append('circle') | ||
| .attr('id', function(d) {return 'task-' + dag_id.replace(/\./g, '_') + d.state || 'none'}) |
There was a problem hiding this comment.
Much appreciated cleanup @XD-DENG!
I had started on integrating/enforcing ESLint that would ensure this pattern is always used—I need to pick that work back up soon.
github-actions
bot
added
the
okay to merge
|
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest master or amend the last commit of the PR, and push it with --force-with-lease. |
Thanks @ryanahamilton :) The Jinja template usage mixed inside may cause difficulty to automate that? Would be interested to know & learn how this will be done👍 |
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.