Skip to content

Deprecate email credentials from environment variables. #13601

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 30, 2021

Conversation

jmcarp
Copy link
Contributor

@jmcarp jmcarp commented Jan 10, 2021

Email backends fetch credentials from environment variables, but other
credentials are typically stored in connections. This patch deprecates
email credentials from environment variables and checks connections
first. We can drop the environment variable fallback in a future
release.

Based on conversation in #13463. I would like to standardize credential handling in email backends, then add an SES backend separately. I'm marking this as a draft for feedback, and I'll write tests once we agree on an approach. cc @mik-laj

@github-actions
Copy link

The Workflow run is cancelling this PR. Building images for the PR has failed. Follow the the workflow link to check the reason.

@github-actions
Copy link

The Workflow run is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Backport packages$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*.

@jmcarp jmcarp force-pushed the jmcarp/email-connections branch 2 times, most recently from 5ba200e to 9a15c2f Compare January 18, 2021 15:08
@github-actions
Copy link

The Workflow run is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Backport packages$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*.

@jmcarp jmcarp force-pushed the jmcarp/email-connections branch from 9a15c2f to c7d15bc Compare January 19, 2021 19:04
@github-actions
Copy link

The Workflow run is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Backport packages$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*.

@jmcarp jmcarp force-pushed the jmcarp/email-connections branch 3 times, most recently from 9a6f7f2 to 37bcdf6 Compare January 21, 2021 02:24
Email backends fetch credentials from environment variables, but other
credentials are typically stored in connections. This patch deprecates
email credentials from environment variables and checks connections
first. We can drop the environment variable fallback in a future
release.
@jmcarp jmcarp force-pushed the jmcarp/email-connections branch from 37bcdf6 to c104778 Compare January 21, 2021 03:35
@jmcarp jmcarp marked this pull request as ready for review January 22, 2021 01:36
@jmcarp jmcarp requested a review from mik-laj January 22, 2021 01:36
@jmcarp
Copy link
Contributor Author

jmcarp commented Jan 22, 2021

OK, ready for review!

Copy link
Member

@potiuk potiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@potiuk potiuk added this to the Airflow 2.1 milestone Jan 30, 2021
@potiuk potiuk merged commit 86695b6 into apache:master Jan 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants