Deprecate email credentials from environment variables. #13601
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Email backends fetch credentials from environment variables, but other
credentials are typically stored in connections. This patch deprecates
email credentials from environment variables and checks connections
first. We can drop the environment variable fallback in a future
release.
Based on conversation in #13463. I would like to standardize credential handling in email backends, then add an SES backend separately. I'm marking this as a draft for feedback, and I'll write tests once we agree on an approach. cc @mik-laj