Have proper default for webserver.expose_config in Helm Chart #13596
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
webserver.expose_config should have consistent default value with the normal Airflow default settings (False). This helps encourage safer setting up in Helm context, also avoid accidental exposure of config (if users don't carefully check the config before install the chart)
XD-DENG
commented
Jan 10, 2021
| @@ -134,7 +134,7 @@ helm upgrade airflow . \ | |||
|
|
|||
| ## Mounting DAGS using Git-Sync side car without Persistence | |||
|
|
|||
| This option will use an always running Git-Sync side car on every scheduler,webserver and worker pods. The Git-Sync side car containers will sync DAGs from a git repository every configured number of seconds. If you are using the KubernetesExecutor, Git-sync will run as an initContainer on your worker pods. | |||
| This option will use an always running Git-Sync side car on every scheduler, webserver and worker pods. The Git-Sync side car containers will sync DAGs from a git repository every configured number of seconds. If you are using the KubernetesExecutor, Git-sync will run as an initContainer on your worker pods. | |||
There was a problem hiding this comment.
This is a simple typo fix. Not related to the scope of this PR. Not worth creating a separate PR.
XD-DENG
commented
Jan 10, 2021
| @@ -705,7 +705,6 @@ config: | |||
| statsd_host: '{{ printf "%s-statsd" .Release.Name }}' | |||
| webserver: | |||
| enable_proxy_fix: 'True' | |||
| expose_config: 'True' | |||
There was a problem hiding this comment.
I simply remove this line, so the default value in default_airflow.cfg is used.
kaxil
approved these changes
Jan 11, 2021
kaxil
pushed a commit
that referenced
this pull request
Jan 21, 2021
webserver.expose_config should have consistent default value with the normal Airflow default settings (False). This helps encourage safer setting up in Helm context, also avoid accidental exposure of config (if users don't carefully check the config before install the chart) (cherry picked from commit 8fd0e45)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Configuration
webserver.expose_configshould have consistent default value with the normal Airflow default settings (False). So we can simply remove it invalues.yaml, so default value indefault_airflow.cfgis respected.This helps encourage safer setting up in Helm context, also avoid accidental exposure of config (if users don't carefully check the config before install the chart).
Ref: Slack discussion https://apache-airflow.slack.com/archives/CCPRP7943/p1610213808438200
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.