Skip to content

Conversation

@juneoh
Copy link

@juneoh juneoh commented Nov 23, 2020

Add the missing ORC format into the allowlist in BigQueryHook load jobs, in order to fully support all formats provided in BigQuery API.

Closes: #12556

@boring-cyborg boring-cyborg bot added the provider:google Google (including GCP) related issues label Nov 23, 2020
@boring-cyborg
Copy link

boring-cyborg bot commented Nov 23, 2020

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst)
Here are some useful points:

  • Pay attention to the quality of your code (flake8, pylint and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it’s a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

@github-actions
Copy link

The Workflow run is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Backport packages$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*.

@github-actions
Copy link

The Workflow run is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Backport packages$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*.

@turbaszek
Copy link
Member

The run_load method is deprecated and users should use insert_job method which supports everything possible 😉

@juneoh
Copy link
Author

juneoh commented Nov 23, 2020

Thanks turbaszek for the feedback. As GCSToBigQueryOperator still relies on BigQueryHook.run_load(), I though it would be quicker to change the method albeit deprecated, rather than to rewrite the operator.

But you are right, deprecated is deprecated, so I do agree to the sentiment. As run_load is a validation wrapper on top of insert_job, would you rather recommend moving that validation into GCSToBigQueryOperator instead, to eliminate the deprecated run_load path and call insert_job directly?

@juneoh
Copy link
Author

juneoh commented Nov 23, 2020

Oops, turbaszek has already provided a kind comment at #12556 (comment). Looks like there is already a different PR that should resolve the deprecated path as well.

Thanks turbaszek, I'll close this PR and follow the other thread!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

provider:google Google (including GCP) related issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add ORC support to GCSToBigQueryOperator

2 participants