Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Additional extras #8866

Closed
potiuk opened this issue May 14, 2020 · 2 comments · Fixed by #9035
Closed

Additional extras #8866

potiuk opened this issue May 14, 2020 · 2 comments · Fixed by #9035
Assignees
@potiuk
Labels
area:production-image Production image improvements and fixes kind:feature Feature Requests
Milestone
Airflow 1.10.11

Comments

@potiuk
Copy link
Member

potiuk commented May 14, 2020

Description

It would be great to be able to pass "ADDITIONAL_EXTRAS" build arg and add extras to the "base" extras of Production Docker image.

Use case / motivation

If someone wants to add just one extra, they might want to specify only that one extra to add rather than copy the whole list

Related Issues

It's been discussed in #8605 (comment)
@potiuk potiuk added kind:feature Feature Requests area:production-image Production image improvements and fixes labels May 14, 2020
@potiuk potiuk self-assigned this May 14, 2020
@potiuk potiuk mentioned this issue May 25, 2020
Closed
@wittfabian
Copy link
Contributor

Which name is better?
"ADDITIONAL_EXTRAS" or "AIRLOW_ADDITIONAL_EXTRAS"

This was referenced May 27, 2020
Merged
Merged
@potiuk
Copy link
Member Author

potiuk commented May 27, 2020

I used to use AIRFLOW everywher, but ... AIRFLOW is the whole context so we know those are AIRFLOW extras :)

potiuk added a commit to PolideaInternal/airflow that referenced this issue May 27, 2020
@potiuk
Additional python extras and deps can be set in breeze
a7171f7 
Closes apache#8604
Closes apache#8866
@potiuk potiuk mentioned this issue May 27, 2020
Merged
6 tasks
potiuk added a commit that referenced this issue May 27, 2020
@potiuk
Additional python extras and deps can be set in breeze (#9035)
7386670 
Closes #8604
Closes #8866
@potiuk potiuk mentioned this issue May 27, 2020
Closed
potiuk added a commit that referenced this issue Jun 9, 2020
@potiuk
Additional python extras and deps can be set in breeze (#9035)
62c97ed 
Closes #8604
Closes #8866

(cherry picked from commit 7386670)
@potiuk potiuk added this to the Airflow 1.10.11 milestone Jun 26, 2020
kaxil pushed a commit that referenced this issue Jul 1, 2020
@potiuk @kaxil
Additional python extras and deps can be set in breeze (#9035)
5683783 
Closes #8604
Closes #8866

(cherry picked from commit 7386670)
cfei18 pushed a commit to cfei18/incubator-airflow that referenced this issue Mar 5, 2021
@potiuk
Additional python extras and deps can be set in breeze (apache#9035)
9957f18 
Closes apache#8604
Closes apache#8866

(cherry picked from commit 7386670)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@potiuk potiuk

Labels
area:production-image Production image improvements and fixes kind:feature Feature Requests
Projects
None yet
Milestone
Airflow 1.10.11
Development

Successfully merging a pull request may close this issue.

Additional python extras and deps can be set in breeze PolideaInternal/airflow
2 participants
@potiuk @wittfabian