Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove _get_pretty_exception_message from PrestoHook #8530

Closed
jeffolsi opened this issue Apr 23, 2020 · 0 comments
Closed

remove _get_pretty_exception_message from PrestoHook #8530

jeffolsi opened this issue Apr 23, 2020 · 0 comments
Labels
good first issue kind:bug This is a clearly a bug

Comments

@jeffolsi
Copy link

What happened:

There is no actual need for _get_pretty_exception_message this Hook is the only hook of DBs that is trying to wrap the exception raised from the db itself.
Airflow needs to be consistent either do this for all hooks or don't do it at all.
There is no reason to do this for Presto but not for Postgresql or Mysql
https://github.com/apache/airflow/blob/v1-10-stable/airflow/hooks/presto_hook.py#L74

@jeffolsi jeffolsi added the kind:bug This is a clearly a bug label Apr 23, 2020
fusuiyi123 added a commit to fusuiyi123/airflow that referenced this issue May 2, 2020
@mik-laj mik-laj closed this as completed in 1100cea May 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue kind:bug This is a clearly a bug
Projects
None yet
Development

No branches or pull requests

2 participants