Skip to content

Missing templating in api server extra init containers #60780

@thejoeejoee

Description

@thejoeejoee

Official Helm Chart version

1.18.0 (latest released)

Apache Airflow version

3.1.6

Kubernetes Version

1.35

Helm Chart configuration

No response

Docker Image customizations

not relevant

What happened

apiServer extraInitContainers are documented as templated:

airflow/chart/values.yaml

Lines 1715 to 1716 in c93cb32

# Add additional init containers into API server (templated).
extraInitContainers: []

but the code itself does not use templating:

{{- toYaml .Values.apiServer.extraInitContainers | nindent 8 }}

What you think should happen instead

tpl should be used as in other workloads

How to reproduce

values.yaml

airflow:
  apiServer:
    extraInitContainers:
      - name: custom-init-container
        image: alpine:latest
        command:
          - sh
          - -c
          - echo {{ "foobar" }}
❯ helm template airflow-init-test . | grep custom-init-container -B5
        - command:
          - sh
          - -c
          - echo {{ "foobar" }}
          image: alpine:latest
          name: custom-init-container

Anything else

it works fine if used in triggerer/...

Are you willing to submit PR?

  • Yes I am willing to submit a PR!

Code of Conduct

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions