-
Notifications
You must be signed in to change notification settings - Fork 16.4k
Closed
Closed
Copy link
Labels
area:helm-chartAirflow Helm ChartAirflow Helm Chartkind:bugThis is a clearly a bugThis is a clearly a bugneeds-triagelabel for new issues that we didn't triage yetlabel for new issues that we didn't triage yet
Description
Official Helm Chart version
1.18.0 (latest released)
Apache Airflow version
3.0.2
Kubernetes Version
v1.32.10
Helm Chart configuration
revisionHistoryLimit: 0Docker Image customizations
No response
What happened
Setting revisionHistoryLimit: 0 in values.yaml is silently ignored. The rendered manifests do not include the revisionHistoryLimit field, causing Kubernetes to use its default value (10) instead of keeping zero old ReplicaSets.
What you think should happen instead
Setting revisionHistoryLimit: 0 should render revisionHistoryLimit: 0 in the deployment manifests, allowing users to disable ReplicaSet history retention.
How to reproduce
- Set in values.yaml:
revisionHistoryLimit: 0- Render the templates:
helm template airflow apache-airflow/airflow --set revisionHistoryLimit=0 | grep -A2 revisionHistoryLimitAnything else
The templates use a truthy check:
{{- if .Values.revisionHistoryLimit }}
revisionHistoryLimit: {{ .Values.revisionHistoryLimit }}
{{- end }}In Go templates, 0 evaluates to false, so the block is skipped.
Are you willing to submit PR?
- Yes I am willing to submit a PR!
Code of Conduct
- I agree to follow this project's Code of Conduct
jx2lee
Metadata
Metadata
Assignees
Labels
area:helm-chartAirflow Helm ChartAirflow Helm Chartkind:bugThis is a clearly a bugThis is a clearly a bugneeds-triagelabel for new issues that we didn't triage yetlabel for new issues that we didn't triage yet