AIP-84 Add asset.id to Dag Dependencies Graph

[bbovenzi]

Description

Most of the API for Assets requires us to use asset_id. But that is just an integer and is not readable. We should update the API, that anywhere we require asset_id we also allow using uri.

Create Asset Event
Get Asset
Get Asset Alias
Materialize an asset
Filter Asset events by a specific asset
Get queued events for an asset

I wonder if we should expose asset.id at all.

Let's add asset.id to the Serialized Dag Model and expose it in the Dag Dependencies endpoint so we can fetch asset details in a graph

Use case/motivation

No response

Related issues

No response

Are you willing to submit a PR?

• Yes I am willing to submit a PR!

Code of Conduct

• I agree to follow this project's Code of Conduct

[bbovenzi]

cc: @pierrejeambrun @uranusjr Let me know if uri is still the correct field to use here

[pierrejeambrun]

This was purposely modified in #44801.

I think that the UI should never display the id. But the id is useful as a technical identifier to communicate between the UI and the API. (or a client and the API). I agree that the uri is a more natural identifier but unfortunately as mentioned in the linked PR it creates issues.

When we fetch AssetEvents or Assets, both id and uri are specified. There shouldn't be any friction getting the associated id for the uri of interest when making the request.

Do you have a use case in mind that has trouble working with id instead of uri ?

[bbovenzi]

Got it. And we can't assume that asset.name is unique either?

In, #47162, I had to put the asset.id integer in the url which I would really like to avoid. Also, the dag dependencies graph doesn't contain the asset.id. That is why I didn't yet allow navigating between assets in the dependencies graph

[pierrejeambrun]

Yes I understand, that's not ideal. Indeed asset.name is not unique.

For the dependencies it's a problem too, because I don't think the asset 'id' is serialized to the SerializedDag model... only the name :(

[bbovenzi]

Ok so I guess for this graph.

I could call get /assets with name_pattern and dag_ids specified:

That isn't great...

@uranusjr or @Lee-W could we update the SerializedDag model to include asset.id at least?

[Lee-W]

Ok so I guess for this graph.

I could call get /assets with name_pattern and dag_ids specified:

That isn't great...

@uranusjr or @Lee-W could we update the SerializedDag model to include asset.id at least?

yep, it should be doable

[bbovenzi]

Cool. I just updated this issue's title and description to focus on the SerializedDagModel and dag dependencies graph

[Lee-W]

draft PR #47365

for assets, it might be easier. but for asset name ref, uri ref, I'm not sure 🤔 will need to take a deeper look