[airflow 2.4.3] presto queries returning none following upgrade to common.sql provider

[yanivsin]

Apache Airflow version

Other Airflow 2 version (please specify below)

What happened

After upgrading apache-airflow-providers-common-sql from 1.2.0 to anything above 1.3.0 presto queries using the get_records() and or get_first() function returns none.

using the same query -- select 1:
1.2.0: Done. Returned value was: [[1]]
1.3.0 and above:

Running statement: select 1, parameters: None
[2023-05-30, 11:57:37 UTC] {{python.py:177}} INFO - Done. Returned value was: None

What you think should happen instead

i would expect that running the query select 1 on presto would provide the same result when the environment is running apache-airflow-providers-common-sql 1.2.0 or apache-airflow-providers-common-sql 1.5.1.

How to reproduce

run the following query: PrestoHook(conn_id).get_records(select 1)
ensure that the requirements are as labelled below.

Operating System

NAME="Amazon Linux" VERSION="2" ID="amzn" ID_LIKE="centos rhel fedora"

Versions of Apache Airflow Providers

apache-airflow==2.4.3
apache-airflow-providers-amazon==6.0.0
apache-airflow-providers-celery==3.0.0
apache-airflow-providers-common-sql==1.5.1
apache-airflow-providers-ftp==3.1.0
apache-airflow-providers-google==8.4.0
apache-airflow-providers-http==4.0.0
apache-airflow-providers-imap==3.0.0
apache-airflow-providers-jenkins==3.0.0
apache-airflow-providers-mysql==3.2.1
apache-airflow-providers-postgres==5.2.2
apache-airflow-providers-presto==5.1.0
apache-airflow-providers-sendgrid==3.0.0
apache-airflow-providers-slack==6.0.0
apache-airflow-providers-snowflake==3.3.0
apache-airflow-providers-sqlite==3.2.1
apache-airflow-providers-trino==4.1.0

Deployment

Official Apache Airflow Helm Chart

Deployment details

No response

Anything else

No response

Are you willing to submit PR?

• Yes I am willing to submit a PR!

Code of Conduct

• I agree to follow this project's Code of Conduct

[boring-cyborg]

Thanks for opening your first issue here! Be sure to follow the issue template! If you are willing to raise PR to address this issue please do so, no need to wait for approval.

[hussein-awala]

#26944 added a condition on cursor.description before returning the result, could you try executing this one?

PrestoHook(conn_id).run(sql="<your query>", handler=lambda cursor: cursor.fetchall())

[yanivsin]

thank you @hussein-awala. this works.

In continuation with the issue, at the moment the sql sensor for presto queries is broken as all get_records() queries return None. i've created this #31630 pr which i believe should fix the issue. WDYT?

[hussein-awala]

We should know why the description is None (it should not be), and if we need to change something, we should do that in the presto provider and not the common sql. I will do some tests from my side

[yanivsin]

thank you.

[eladkal]

Is the issue from Airflow side or Presto SDK?
We had previous case of #26774 (comment) that turned not to be Airflow issue.
Can we confirm if the SDK work as expected ?