Skip to content

Commit

Permalink
fix tests
Browse files Browse the repository at this point in the history
  • Loading branch information
dstandish committed Jan 4, 2023
1 parent 6280275 commit 776b819
Showing 1 changed file with 10 additions and 3 deletions.
13 changes: 10 additions & 3 deletions tests/task/task_runner/test_standard_task_runner.py
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@
from contextlib import contextmanager
from pathlib import Path
from unittest import mock
from unittest.mock import patch

import psutil
import pytest
Expand Down Expand Up @@ -89,7 +90,9 @@ def setup_class(self):
clear_db_runs()
get_listener_manager().clear()

def test_start_and_terminate(self):
@patch("airflow.utils.log.file_task_handler.FileTaskHandler._init_file")
def test_start_and_terminate(self, mock_init):
mock_init.return_value = "/tmp/any"
local_task_job = mock.Mock()
local_task_job.task_instance = mock.MagicMock()
local_task_job.task_instance.run_as_user = None
Expand Down Expand Up @@ -163,7 +166,9 @@ def test_notifies_about_start_and_stop(self):
assert f.readline() == "on_starting\n"
assert f.readline() == "before_stopping\n"

def test_start_and_terminate_run_as_user(self):
@patch("airflow.utils.log.file_task_handler.FileTaskHandler._init_file")
def test_start_and_terminate_run_as_user(self, mock_init):
mock_init.return_value = "/tmp/any"
local_task_job = mock.Mock()
local_task_job.task_instance = mock.MagicMock()
local_task_job.task_instance.task_id = "task_id"
Expand Down Expand Up @@ -197,12 +202,14 @@ def test_start_and_terminate_run_as_user(self):
assert runner.return_code() is not None

@propagate_task_logger()
def test_early_reap_exit(self, caplog):
@patch("airflow.utils.log.file_task_handler.FileTaskHandler._init_file")
def test_early_reap_exit(self, mock_init, caplog):
"""
Tests that when a child process running a task is killed externally
(e.g. by an OOM error, which we fake here), then we get return code
-9 and a log message.
"""
mock_init.return_value = "/tmp/any"
local_task_job = mock.Mock()
local_task_job.task_instance = mock.MagicMock()
local_task_job.task_instance.task_id = "task_id"
Expand Down

0 comments on commit 776b819

Please sign in to comment.