Skip to content

Commit

Permalink
Remove pendulum as dependency of breeze (#35786)
Browse files Browse the repository at this point in the history
For some reason (likely importing some stuff from setup.py in the
old days) pendulum was added as dependency in breeze - which still
caused a problem when `pipx` decided to use Python 3.12 to install
Breeze (despite #35652 that was supposed to supersede #35620).

The #35620 adding a need to specify python additionally when you
install breeze added it's own complexity (which python?), it
turns out that breeze does not need to have pendulum installed
at all now (we stopped depending on airflow being installed
and stopped importing things from setup.py or __version__ in
favour of directly parsing __version__ variable from python code.

This PR removes pendulum entirely as Breeze dependency.
  • Loading branch information
potiuk authored and ephraimbuddy committed Nov 26, 2023
1 parent d35e982 commit 07a4b8b
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 2 deletions.
2 changes: 1 addition & 1 deletion dev/breeze/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,6 @@ PLEASE DO NOT MODIFY THE HASH BELOW! IT IS AUTOMATICALLY UPDATED BY PRE-COMMIT.

---------------------------------------------------------------------------------------------------------

Package config hash: a5878ba073fa5924f21660531f0988f287269f0d3aca741095cad62b3a1f3ccb262f76df203aff1f02cfec691f839da02bc6844342f49e40f896a1c9b3c450d8
Package config hash: c7d80ab49c6dc4bf2b54957663b0126ab9c8f48df28a34c0eb56340540cb1f52d063ef99ee5f9cacbd375b1a711278884f9ef9aab41e620fa70fffd81f7ece3c

---------------------------------------------------------------------------------------------------------
1 change: 0 additions & 1 deletion dev/breeze/pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,6 @@ dependencies = [
"jinja2>=3.1.0",
"jsonschema>=4.19.1",
"packaging>=23.2",
"pendulum>=2.1.2,<3",
"pre-commit>=3.5.0",
"psutil>=5.9.6",
"pygithub>=2.1.1",
Expand Down

0 comments on commit 07a4b8b

Please sign in to comment.