Skip to content

Conversation

@SHASHI9705
Copy link
Contributor

@SHASHI9705 SHASHI9705 commented Dec 13, 2025

What does this PR do?

Fixes inconsistent hover and underline behavior on links in the Community page,
ensuring a consistent visual experience across all community link items.

Why is this needed?

Currently, some Community page links show different underline or hover effects,
which feels visually inconsistent and distracting.

@potiuk

Copy link
Member

@choo121600 choo121600 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!
However, this PR also contains some unrelated changes and commits.
Could you please remove any changes that are not related to what this PR aims to achieve?

@SHASHI9705
Copy link
Contributor Author

Good catch! However, this PR also contains some unrelated changes and commits. Could you please remove any changes that are not related to what this PR aims to achieve?

i have removed unnecessary changes, kindly review the pr and merge it. @choo121600

Copy link
Member

@choo121600 choo121600 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And please upload a screenshot

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are still unnecessary changes remaining.

@choo121600
Copy link
Member

A reviewer’s time is valuable. Jarek is very active not only on this website but also across the Apache Airflow project.
Please make sure to review your code yourself before requesting a review via a mention.
Thank you for your interest in contributing and for submitting multiple PRs 🙂

@SHASHI9705
Copy link
Contributor Author

beforeafteruilinkk.mp4

Now i have reverted the unnecessary changes, looks ok ? @choo121600

@SHASHI9705
Copy link
Contributor Author

A reviewer’s time is valuable. Jarek is very active not only on this website but also across the Apache Airflow project. Please make sure to review your code yourself before requesting a review via a mention. Thank you for your interest in contributing and for submitting multiple PRs 🙂

Understood — thank you for the guidance. I’ll be more careful to self-review before requesting a review.

@SHASHI9705 SHASHI9705 force-pushed the fix-communitypage-link-hover-underline branch from 606f87b to 517630d Compare December 13, 2025 09:09
@potiuk
Copy link
Member

potiuk commented Dec 13, 2025

Also for the future - @SHASHI9705 -> don't tag individual maintainers (like me) - maintainers will look at PRs (lie @choo121600 ) and reivew when they have free time, not when they are called - and actually when you tag someone, and they are not available, you decrease your chances for someone else to review and merge your PR.

@SHASHI9705
Copy link
Contributor Author

Also for the future - @SHASHI9705 -> don't tag individual maintainers (like me) - maintainers will look at PRs (lie @choo121600 ) and reivew when they have free time, not when they are called - and actually when you tag someone, and they are not available, you decrease your chances for someone else to review and merge your PR.

Understood @potiuk sir, thank you for the guidance. I’ll be more careful from next time.

@potiuk
Copy link
Member

potiuk commented Dec 13, 2025

It's not restored now - it's replaced by a copy of the file.

@SHASHI9705
Copy link
Contributor Author

It's not restored now - it's replaced by a copy of the file.

Thanks for your patience and for clarifying this.
You’re right sir! integrations.json was a symbolic link, and I initially misunderstood it on Windows. I’ve now restored it correctly as a symlink using WSL and verified it’s tracked properly by Git.
Apologies for the noise from earlier commits — I’ll be more careful to review and verify changes before proposing fixes.

@potiuk
Copy link
Member

potiuk commented Dec 13, 2025

It's still not proper - if it would be proper, then there would be no change in your PR for that symlink - and currently it seems it is changed with EOL change

@SHASHI9705 SHASHI9705 force-pushed the fix-communitypage-link-hover-underline branch from a790415 to 84b16ca Compare December 13, 2025 15:39
@SHASHI9705
Copy link
Contributor Author

SHASHI9705 commented Dec 13, 2025

It's still not proper - if it would be proper, then there would be no change in your PR for that symlink - and currently it seems it is changed with EOL change

You’re right Sir the symlink should not be touched. I reset the branch and re-applied only the intended UI change, so the PR now contains a single clean commit with no symlink or infra changes. If everything looks good kindly verify and merge it.

@SHASHI9705 SHASHI9705 requested a review from potiuk December 13, 2025 16:38
@choo121600
Copy link
Member

The unnecessary changes seem to be resolved now 👍

However, I have a small suggestion. I noticed that the list-link style was removed in html. as far as I can tell, this css class was only used in the code that was removed.

In this case, there seem to be two possible options:

  • Revert the removal of the list-link style and reuse it for other links
  • If the list-link style is no longer needed, remove it from the css as well.

Personally, since the list-link style has already been removed from the HTML, cleaning it up from the css as well.
What do you think?

Copy link
Member

@choo121600 choo121600 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This

.list-link {
@extend .bodytext__medium--greyish-brown;
text-decoration: underline;
}

@choo121600
Copy link
Member

Feel free to choose either option😉
once one of them is addressed, this looks Good to me.

@SHASHI9705
Copy link
Contributor Author

The unnecessary changes seem to be resolved now 👍

However, I have a small suggestion. I noticed that the list-link style was removed in html. as far as I can tell, this css class was only used in the code that was removed.

In this case, there seem to be two possible options:

  • Revert the removal of the list-link style and reuse it for other links
  • If the list-link style is no longer needed, remove it from the css as well.

Personally, since the list-link style has already been removed from the HTML, cleaning it up from the css as well. What do you think?

Yes i think the 2nd option looks good , I'll clean up that part and commit again.

@SHASHI9705
Copy link
Contributor Author

SHASHI9705 commented Dec 13, 2025

Feel free to choose either option😉 once one of them is addressed, this looks Good to me.

Yes i have chosen 2nd , and also updated the file , LGTM for merging it.

Copy link
Member

@choo121600 choo121600 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)
I hope this PR helped you learn some of the expectations when submitting PRs to an open-source community.
I’m looking forward to your future contributions 😉

@potiuk
Copy link
Member

potiuk commented Dec 14, 2025

Upgrade fix in #1322

@potiuk potiuk merged commit 1702e05 into apache:main Dec 14, 2025
1 of 2 checks passed
kaxil pushed a commit that referenced this pull request Dec 16, 2025
…#1318)

* Fix community page link hover underline

* Removed list-link, no longer needed
@SHASHI9705 SHASHI9705 deleted the fix-communitypage-link-hover-underline branch January 24, 2026 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants