-
Notifications
You must be signed in to change notification settings - Fork 416
Fix inconsistent hover and underline behavior on Community page links #1318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix inconsistent hover and underline behavior on Community page links #1318
Conversation
choo121600
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch!
However, this PR also contains some unrelated changes and commits.
Could you please remove any changes that are not related to what this PR aims to achieve?
i have removed unnecessary changes, kindly review the pr and merge it. @choo121600 |
choo121600
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And please upload a screenshot
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are still unnecessary changes remaining.
|
A reviewer’s time is valuable. Jarek is very active not only on this website but also across the Apache Airflow project. |
beforeafteruilinkk.mp4Now i have reverted the unnecessary changes, looks ok ? @choo121600 |
Understood — thank you for the guidance. I’ll be more careful to self-review before requesting a review. |
606f87b to
517630d
Compare
|
Also for the future - @SHASHI9705 -> don't tag individual maintainers (like me) - maintainers will look at PRs (lie @choo121600 ) and reivew when they have free time, not when they are called - and actually when you tag someone, and they are not available, you decrease your chances for someone else to review and merge your PR. |
Understood @potiuk sir, thank you for the guidance. I’ll be more careful from next time. |
|
It's not restored now - it's replaced by a copy of the file. |
Thanks for your patience and for clarifying this. |
|
It's still not proper - if it would be proper, then there would be no change in your PR for that symlink - and currently it seems it is changed with EOL change |
a790415 to
84b16ca
Compare
You’re right Sir the symlink should not be touched. I reset the branch and re-applied only the intended UI change, so the PR now contains a single clean commit with no symlink or infra changes. If everything looks good kindly verify and merge it. |
|
The unnecessary changes seem to be resolved now 👍 However, I have a small suggestion. I noticed that the list-link style was removed in html. as far as I can tell, this css class was only used in the code that was removed. In this case, there seem to be two possible options:
Personally, since the list-link style has already been removed from the HTML, cleaning it up from the css as well. |
choo121600
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This
airflow-site/landing-pages/site/assets/scss/_community-page.scss
Lines 21 to 26 in 55a9336
| .list-link { | |
| @extend .bodytext__medium--greyish-brown; | |
| text-decoration: underline; | |
| } | |
|
Feel free to choose either option😉 |
Yes i think the 2nd option looks good , I'll clean up that part and commit again. |
Yes i have chosen 2nd , and also updated the file , LGTM for merging it. |
choo121600
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM :)
I hope this PR helped you learn some of the expectations when submitting PRs to an open-source community.
I’m looking forward to your future contributions 😉
|
Upgrade fix in #1322 |
…#1318) * Fix community page link hover underline * Removed list-link, no longer needed
What does this PR do?
Fixes inconsistent hover and underline behavior on links in the Community page,
ensuring a consistent visual experience across all community link items.
Why is this needed?
Currently, some Community page links show different underline or hover effects,
which feels visually inconsistent and distracting.
@potiuk