[AMQ-9856] Journal move fails on Windows#1654
Open
jeanouii wants to merge 2 commits intoapache:mainfrom
Open
Conversation
Contributor
Author
|
FYI, here is the stack trace on Windows |
Contributor
|
A debug on macos confirmed that when the move is requested, the db-6.log file is not opened by the Java process. Note: This may be a race condition if close is async. |
Contributor
|
The exception is wrapped and the original exception and stacktrace is lost-- I made a quick change to see if we can get the full stacktrace ref: #1655 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To be discussed. On Github Actions for Windows nodes, it consistently fails.
On Windows, files cannot be renamed/moved while open by another process. The simplest and most appropriate fix is to skip this test on Windows where file locking makes it inherently unreliable.