AMQ-9625 - Prevent queue messages from becoming stuck #1355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cshannon
force-pushed
the
AMQ-9625
branch
2 times, most recently
from
4ab130b to
4b641ee
Compare
|
I updated the PR slightly as we needed the check/wait for the async to be done not only when the store is being synced, but also for any outstanding in flight async messages that were in progress by other threads when the mode switched. |
Fixes a race condition bug that can lead to a message being missed on dispatch and stuck on a Queue until restart when caching and concurrentStoreAndDispatch are enabled on a Queue and the cache becomes disabled.
|
I'm going to go ahead and merge this as it is low risk (we are just waiting on the pending writes so messages become sync) and it's nearly impossible to write a test case for it. In my testing it has shown some promising results but if the issue re-occurs another Jira can be opened as a follow up. |
mattrpav
reviewed
Nov 21, 2024
...vemq-broker/src/main/java/org/apache/activemq/broker/region/cursors/AbstractStoreCursor.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a race condition bug that can lead to a message being missed on dispatch and stuck on a Queue until restart when caching and concurrentStoreAndDispatch are enabled on a Queue and the cache becomes disabled.
This is pretty much impossible to reproduce or test in a unit test so there's no test for this but the risk of breaking anything is very low because all this is doing is just waiting for the future to complete to ensure the task finishes before we continue.
For a detailed description of the problem see https://issues.apache.org/jira/browse/AMQ-9625