Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AMQ-9430] RuntimeConfigPlugin wire in classloader to JAXBContext #1204

Merged
merged 1 commit into from
Apr 11, 2024

Conversation

mattrpav
Copy link
Contributor

No description provided.

Copy link
Member

@jbonofre jbonofre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I just tested and it works fine on JMX MBean. Thanks !

@mattrpav
Copy link
Contributor Author

mattrpav commented Apr 11, 2024

I confirmed testing this locally using jconsole

 INFO | Manual configuration update triggered
 INFO | No material change to configuration in class path resource [activemq.xml] at: Thu Apr 11 09:31:19 CDT 2024

Background: The issue is activemq distribution uses a different classloader to bootstrap. There is a unit test for jmx invocation, but it is not like-for-like b/c of the runtime differences between the unit test and the apache activemq dist.

This fix should work for all dists, including embedded and osgi (karaf, etc)

@cshannon cshannon merged commit f6d067a into apache:main Apr 11, 2024
1 check was pending
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants