ARTEMIS-2777 Add core federation and broker connections to the management console #5285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryeats
force-pushed
the
managment-update
branch
from
0e792b5
to
d2175ac
Compare
|
I was just thinking about this. This looks like a great contribution. @tabish121 & @clebertsuconic, is there anything else you think needs to be included in this? |
|
Core Federation is essentially unmaintained (and under tested) and should probably be marked as deprecated for removal in a future release. Given that I'd say adding management APIs and code for it seems ill advised. |
|
Core Federation is essentially unmaintained (and under tested) ?? Why do you say this? I mean i don't see any large bug tickets, and its used in a number of commercial bank systems. |
|
Should I remove the core federation management code and mark the core federation API's deprecated and point developers to the AMQP federation then? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a bit out of the blue but basically it has been bugging me how outgoing connections aren't able to be managed in Artemis for anything but Bridges. So I looked into adding something similar primarily for federation but also for the AMQP broker-connections. Simply displaying the configuration didn't seem useful so similar to Bridges i tried to pull up some attribute related to the actual state, for AMQP broker-connections, i exposed if the connection was actually open. For core federations I added visibility into the upstream consumers that are generate from the policy and a message count for messages they have transferred back.