Skip to content
This repository has been archived by the owner on Dec 10, 2021. It is now read-only.

chore: bumping nvd3-fork package #891

Merged
merged 1 commit into from
Jan 8, 2021

Conversation

rusackas
Copy link
Member

@rusackas rusackas commented Jan 8, 2021

💔 Breaking Changes

🏆 Enhancements
Bumping nvd3-fork which has a recent change pulled in to fix apache/superset#12201. Hat tip to @maloun96 for doing the detective work here.

📜 Documentation

🐛 Bug Fix

🏠 Internal

@rusackas rusackas requested a review from a team as a code owner January 8, 2021 06:53
@vercel
Copy link

vercel bot commented Jan 8, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/superset/superset-ui/4no0jliej
✅ Preview: https://superset-ui-git-fork-preset-io-update-nvd3-fork.superset.vercel.app

@codecov
Copy link

codecov bot commented Jan 8, 2021

Codecov Report

Merging #891 (9fa6774) into master (fc34e8c) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #891   +/-   ##
=======================================
  Coverage   26.55%   26.55%           
=======================================
  Files         404      404           
  Lines        8238     8238           
  Branches     1120     1120           
=======================================
  Hits         2188     2188           
  Misses       5922     5922           
  Partials      128      128           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fc34e8c...9fa6774. Read the comment docs.

@rusackas rusackas merged commit a918fc5 into apache-superset:master Jan 8, 2021
@rusackas rusackas deleted the update-nvd3-fork branch January 8, 2021 07:14
@ktmud
Copy link
Contributor

ktmud commented Jan 8, 2021

Thanks for working out a fix so fast! I know it's not fun to having to work across 3 repos!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Chart]Line Chart Time Series markers not correct after zoom
3 participants