feat(legacy-plugin-chart-sunburst): add linear color scheme #714
Conversation
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/superset/superset-ui/9tw9opisy |
| controlSetRows: [['color_scheme', 'label_colors']], | ||
| controlSetRows: [['color_scheme', 'linear_color_scheme']], |
There was a problem hiding this comment.
the label_colors control isn't used anywhere in this chart, and actually doesn't work (shows up blank). Interestingly enough it's used in several charts. Deferring looking into this to a later PR.
Codecov Report
@@ Coverage Diff @@
## master #714 +/- ##
=======================================
Coverage 24.19% 24.19%
=======================================
Files 339 339
Lines 7617 7617
Branches 925 925
=======================================
Hits 1843 1843
Misses 5701 5701
Partials 73 73
Continue to review full report at Codecov.
|
| }, | ||
| linear_color_scheme: { | ||
| description: t('When a secondary metric is provided, a linear color scale is used.'), | ||
| }, |
There was a problem hiding this comment.
We could swap this based on the control state when the secondary metric is provided, but maybe that'd be too jarring to the user to just have the color scheme automatically change.
🏆 Enhancements
Currently sunburst chart uses a linear color scheme when using a secondary metric that can't be customized. This adds a linear color control and uses that when the secondary metric is defined.
Screenshot