Skip to content
This repository has been archived by the owner on Dec 10, 2021. It is now read-only.

chore: translate fractional time grains #1404

Conversation

john-bodley
Copy link
Contributor

@john-bodley john-bodley commented Oct 13, 2021

💔 Breaking Changes

🏆 Enhancements

📜 Documentation

🐛 Bug Fix

🏠 Internal

Updating the time grain definitions as described in apache/superset#17078 —which is dependent on this change.

@john-bodley john-bodley requested a review from a team as a code owner October 13, 2021 01:37
@vercel
Copy link

vercel bot commented Oct 13, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/superset/superset-ui/E8epGdjRwj7HE6BYxgaPxGK2MhUK
✅ Preview: https://superset-ui-git-fork-john-bodley-john-bodley-db-f6ef45-superset.vercel.app

Copy link
Contributor

@betodealmeida betodealmeida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. Unfortunately I no longer remember why I used fractional time grains initially.

@codecov
Copy link

codecov bot commented Oct 13, 2021

Codecov Report

Merging #1404 (089a642) into master (e5e8b66) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1404   +/-   ##
=======================================
  Coverage   30.41%   30.41%           
=======================================
  Files         497      497           
  Lines        9996     9996           
  Branches     1687     1687           
=======================================
  Hits         3040     3040           
  Misses       6710     6710           
  Partials      246      246           
Impacted Files Coverage Δ
...-core/src/time-format/TimeFormatsForGranularity.ts 100.00% <ø> (ø)
packages/superset-ui-core/src/time-format/types.ts 100.00% <ø> (ø)
...ime-format/utils/createTimeRangeFromGranularity.ts 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e5e8b66...089a642. Read the comment docs.

@john-bodley john-bodley changed the title chore: translate fractional time grains chore(core): translate fractional time grains Oct 13, 2021
@john-bodley john-bodley changed the title chore(core): translate fractional time grains chore: translate fractional time grains Oct 13, 2021
@john-bodley john-bodley merged commit 50d3ddb into apache-superset:master Oct 13, 2021
@john-bodley john-bodley deleted the john-bodley--db-engine-specs-iso8601 branch October 13, 2021 02:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants