This repository was archived by the owner on Jan 9, 2020. It is now read-only.
Logging for resource deletion #170
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove dangling colon and replace with an ellipses and a second log statement
|
LGTM |
ash211
commented
Mar 3, 2017
| resources.values.foreach { resource => | ||
| Utils.tryLogNonFatalError { | ||
| kubernetesClient.resource(resource).delete() | ||
| } | ||
| } | ||
| resources.clear() | ||
| logInfo(s"Deleted ${resourceCount} registered Kubernetes resources.") |
There was a problem hiding this comment.
realized this would return 0 before
|
Looks fine. |
ash211
added a commit
that referenced
this pull request
Mar 8, 2017
* Logging for resource deletion Remove dangling colon and replace with an ellipses and a second log statement * Update KubernetesResourceCleaner.scala
foxish
pushed a commit
that referenced
this pull request
Jul 24, 2017
* Logging for resource deletion Remove dangling colon and replace with an ellipses and a second log statement * Update KubernetesResourceCleaner.scala
ifilonenko
pushed a commit
to ifilonenko/spark
that referenced
this pull request
Feb 25, 2019
* Logging for resource deletion Remove dangling colon and replace with an ellipses and a second log statement * Update KubernetesResourceCleaner.scala (cherry picked from commit c118f47)
ifilonenko
pushed a commit
to ifilonenko/spark
that referenced
this pull request
Feb 25, 2019
puneetloya
pushed a commit
to puneetloya/spark
that referenced
this pull request
Mar 11, 2019
* Logging for resource deletion Remove dangling colon and replace with an ellipses and a second log statement * Update KubernetesResourceCleaner.scala
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove dangling colon and replace with an ellipses and a second log statement