-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding support for NLT marker segment of type 3 #154
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…with it, but it is good for testing.
…he data is around 16bits/sample of more, coded losslessly.
…. Also addresses CodeQL.
…ify -bit_depth for .pfm files -- this temporary.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to support NLT marker segment of type 3.
This should enable lossless compression of 16-bit floating point data, or 32-bit floating data that has been truncated to, say, 24-bits.
To support lossless compression of 32-bit float, we need a 64-bit data path, which is possible for a later point in time.
The code has been written for library, but is yet to be debugged.
I also need to expose this feature in ojph_compress and ojph_expand, which I have not done yet.
The pull request also changes the number of bits needed for lossless compression of data as in commit 5d888b5, but this unlikely to be noticed by anyone.