Impl config module #23
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #23 +/- ##
==========================================
Coverage ? 78.72%
==========================================
Files ? 197
Lines ? 21468
Branches ? 2056
==========================================
Hits ? 16900
Misses ? 4568
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
|
mykola-kobets-epam
left a comment
mykola-kobets-epam
left a comment
There was a problem hiding this comment.
Reviewed-by: Mykola Kobets <mykola_kobets@epam.com>
mlohvynenko
left a comment
mlohvynenko
left a comment
There was a problem hiding this comment.
Reviewed-by: Mykhailo Lohvynenko <mykhailo_lohvynenko@epam.com>
| @@ -36,6 +36,7 @@ add_subdirectory(logprovider) | |||
| add_subdirectory(migration) | |||
There was a problem hiding this comment.
commit message
common: config:
src/common/config/config.cpp
Outdated
| #include <filesystem> | ||
|
|
||
| #include <common/utils/exception.hpp> | ||
|
|
src/common/config/config.cpp
Outdated
| { | ||
| try { | ||
| const auto pollPeriod = object.GetValue<std::string>("pollPeriod", cDefaultMonitoringPollPeriod); | ||
|
|
| * Functions | ||
| **********************************************************************************************************************/ | ||
|
|
||
| /* |
There was a problem hiding this comment.
I expect here only one method:
/*
* Parses config from file.
*
* @param filename config file name.
* @param[out] config config instance.
* @return Error.
*/
Error ParseConfig(const std::string& filename, Config& config);Similar to SM.
There was a problem hiding this comment.
But this is a general function in common, which is used in SM and CM
MykolaSuperman
force-pushed
the
config
branch
2 times, most recently
from
df82478 to
cf5bd0a
Compare
al1img
left a comment
al1img
left a comment
There was a problem hiding this comment.
Reviewed-by: Oleksandr Grytsov <oleksandr_grytsov@epam.com>
Signed-off-by: Mykola Solianko <mykola_solianko@epam.com> Reviewed-by: Mykola Kobets <mykola_kobets@epam.com> Reviewed-by: Mykhailo Lohvynenko <mykhailo_lohvynenko@epam.com> Reviewed-by: Oleksandr Grytsov <oleksandr_grytsov@epam.com>
Signed-off-by: Mykola Solianko <mykola_solianko@epam.com> Reviewed-by: Mykola Kobets <mykola_kobets@epam.com> Reviewed-by: Mykhailo Lohvynenko <mykhailo_lohvynenko@epam.com> Reviewed-by: Oleksandr Grytsov <oleksandr_grytsov@epam.com>
Signed-off-by: Mykola Solianko <mykola_solianko@epam.com> Reviewed-by: Mykola Kobets <mykola_kobets@epam.com> Reviewed-by: Mykhailo Lohvynenko <mykhailo_lohvynenko@epam.com> Reviewed-by: Oleksandr Grytsov <oleksandr_grytsov@epam.com>
|
4 participants
No description provided.