Skip to content

Conversation

@MykolaSuperman
Copy link

No description provided.

@codecov
Copy link

codecov bot commented Jun 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (develop@19c9798). Learn more about missing BASE report.

Additional details and impacted files
@@            Coverage Diff             @@
##             develop      #18   +/-   ##
==========================================
  Coverage           ?   80.82%           
==========================================
  Files              ?      144           
  Lines              ?    14509           
  Branches           ?     1373           
==========================================
  Hits               ?    11727           
  Misses             ?     2782           
  Partials           ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

scripts/build.sh Outdated
conan remove 'poco*' -c
conan remove 'libcu*' -c
conan remove 'opens*' -c
conan remove 'libp11*' -c
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

libp11 is no longer required, pkcs11-provider is used instead

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

scripts/build.sh Outdated
{
print_next_step "Run static analysis (cppcheck)"

cppcheck --enable=all --inline-suppr -I src --std=c++17 --error-exitcode=1 \
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-I src is not required

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Copy link
Member

@mlohvynenko mlohvynenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed-by: Mykhailo Lohvynenko <mykhailo_lohvynenko@epam.com>


print_usage()
{
echo "Usage: ./build.sh <command> [options]"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add empty "echo"

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

print_usage()
{
echo "Usage: ./build.sh <command> [options]"
echo "Commands:"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

scripts/build.sh Outdated
echo " coverage # run tests with coverage"
echo " lint # run static analysis (cppcheck)"
echo "Options:"
echo " --clean # clean build artifacts"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

align description

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

scripts/build.sh Outdated
{
echo "Usage: ./build.sh <command> [options]"
echo "Commands:"
echo " build # build target"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove # for all string

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

"iam")
with_iam="ON"
;;
"mp")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add empty lines between cases

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

clean_flag=true
shift
;;
--aos-service)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

empty line between cases

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

shift

case "$command" in
build)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@MykolaSuperman MykolaSuperman force-pushed the use_build_script_for_ci branch from fe88fc2 to 9db1069 Compare June 24, 2025 15:59
Copy link
Collaborator

@al1img al1img left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed-by: Oleksandr Grytsov <oleksandr_grytsov@epam.com>

@mykola-kobets-epam
Copy link
Collaborator

Reviewed-by: Mykola Kobets <mykola_kobets@epam.com>

Mykola Solianko added 2 commits June 26, 2025 11:54
Signed-off-by: Mykola Solianko <mykola_solianko@epam.com>
Reviewed-by: Mykhailo Lohvynenko <mykhailo_lohvynenko@epam.com>
Reviewed-by: Oleksandr Grytsov <oleksandr_grytsov@epam.com>
Reviewed-by: Mykola Kobets <mykola_kobets@epam.com>
Signed-off-by: Mykola Solianko <mykola_solianko@epam.com>
Reviewed-by: Mykhailo Lohvynenko <mykhailo_lohvynenko@epam.com>
Reviewed-by: Oleksandr Grytsov <oleksandr_grytsov@epam.com>
Reviewed-by: Mykola Kobets <mykola_kobets@epam.com>
@MykolaSuperman MykolaSuperman force-pushed the use_build_script_for_ci branch from 9db1069 to b2bd636 Compare June 26, 2025 08:56
@sonarqubecloud
Copy link

@al1img al1img merged commit 9443a54 into aosedge:develop Jun 26, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants