-
Notifications
You must be signed in to change notification settings - Fork 5
Use build script for ci #18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use build script for ci #18
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #18 +/- ##
==========================================
Coverage ? 80.82%
==========================================
Files ? 144
Lines ? 14509
Branches ? 1373
==========================================
Hits ? 11727
Misses ? 2782
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
scripts/build.sh
Outdated
| conan remove 'poco*' -c | ||
| conan remove 'libcu*' -c | ||
| conan remove 'opens*' -c | ||
| conan remove 'libp11*' -c |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
libp11 is no longer required, pkcs11-provider is used instead
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
scripts/build.sh
Outdated
| { | ||
| print_next_step "Run static analysis (cppcheck)" | ||
|
|
||
| cppcheck --enable=all --inline-suppr -I src --std=c++17 --error-exitcode=1 \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-I src is not required
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
mlohvynenko
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed-by: Mykhailo Lohvynenko <mykhailo_lohvynenko@epam.com>
|
|
||
| print_usage() | ||
| { | ||
| echo "Usage: ./build.sh <command> [options]" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add empty "echo"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
| print_usage() | ||
| { | ||
| echo "Usage: ./build.sh <command> [options]" | ||
| echo "Commands:" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ditto
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
scripts/build.sh
Outdated
| echo " coverage # run tests with coverage" | ||
| echo " lint # run static analysis (cppcheck)" | ||
| echo "Options:" | ||
| echo " --clean # clean build artifacts" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
align description
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
scripts/build.sh
Outdated
| { | ||
| echo "Usage: ./build.sh <command> [options]" | ||
| echo "Commands:" | ||
| echo " build # build target" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove # for all string
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
| "iam") | ||
| with_iam="ON" | ||
| ;; | ||
| "mp") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add empty lines between cases
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
| clean_flag=true | ||
| shift | ||
| ;; | ||
| --aos-service) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
empty line between cases
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
| shift | ||
|
|
||
| case "$command" in | ||
| build) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ditto
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
fe88fc2 to
9db1069
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed-by: Oleksandr Grytsov <oleksandr_grytsov@epam.com>
|
|
Signed-off-by: Mykola Solianko <mykola_solianko@epam.com> Reviewed-by: Mykhailo Lohvynenko <mykhailo_lohvynenko@epam.com> Reviewed-by: Oleksandr Grytsov <oleksandr_grytsov@epam.com> Reviewed-by: Mykola Kobets <mykola_kobets@epam.com>
Signed-off-by: Mykola Solianko <mykola_solianko@epam.com> Reviewed-by: Mykhailo Lohvynenko <mykhailo_lohvynenko@epam.com> Reviewed-by: Oleksandr Grytsov <oleksandr_grytsov@epam.com> Reviewed-by: Mykola Kobets <mykola_kobets@epam.com>
9db1069 to
b2bd636
Compare
|



No description provided.