Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Artist's albums of the same year disappear #464

Closed
rubenvandeven opened this issue Jun 12, 2024 · 0 comments · Fixed by #474
Closed

Artist's albums of the same year disappear #464

rubenvandeven opened this issue Jun 12, 2024 · 0 comments · Fixed by #474
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@rubenvandeven
Copy link
Contributor

Describe the bug
In the Album pane of the artist page albums that have the same year (and possibly same year) show only once.

To Reproduce
For example, I encountered this looking for Audioslave's Revelations album. It seems to show up on the artist page, but selecting that album refers to an album dated 2006-09-01 with just a single track. I suppose this an EP.

Searching for Revelations does yield the full album and I can open it from there. It is of the same year, but a different day: 2006-08-29. See also the images below.

Expected behaviour
Both albums should show. Ideally they have an indicator how they're different, but as a first step simply having both would already be great.

Screenshots

Overview with just one album:
screenshot_2024-06-12-172612

The selected album just has one track. Album date: 2006-09-01
screenshot_2024-06-12-172620

Album with the same artist, name & year, but different month and day: 2006-08-29. This can be accessed through search.
screenshot_2024-06-12-172557

Environment

  • OS: Linux - Debian testing (Trixie)
  • Application version: 0.18.2 (installed through cargo)
  • Application features: cargo install spotify_player --no-default-features --features pulseaudio-backend,streaming,notify,media-control,sixel
    screenshot_2024-06-12-172620
    screenshot_2024-06-12-172612
    screenshot_2024-06-12-172557
@rubenvandeven rubenvandeven added the bug Something isn't working label Jun 12, 2024
@aome510 aome510 added the good first issue Good for newcomers label Jun 13, 2024
juliamertz pushed a commit to juliamertz/spotify-player that referenced this issue Jul 20, 2024
…0#474)

* fix aome510#464 by removing code to filter duplicates

This commit removes the code previously responsable for filtering
out duplicate album names.

* Display full date next to Albums on Artist page

This change resolves the ambiguity between different
Albums of the same Name.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants