Fix locked array error on texture cleanup #388
+343
−327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![codescene-delta-analysis[bot]](https://avatars.githubusercontent.com/in/53921?s=60&v=4){kind=small}
|
Fellow citizen of Nix, one of the admins verify this pull request |
…pth stencils since it's probably more performant
morgolock
requested changes
Nov 17, 2024
| @@ -271,7 +289,7 @@ End Sub | |||
| Public Function CreateTextureFromData(ByRef Bytes() As Byte, ByVal Size As Long, ByVal Width As Long, ByVal Height As Long) As Direct3DTexture8 | |||
| On Error GoTo ErrHandler | |||
| Dim Texture As Direct3DTexture8 | |||
| Set Texture = mD3D.CreateTextureFromFileInMemoryEx(device, Bytes(0), UBound(Bytes) + 1, Width, Height, 1, 0, D3DFMT_A8R8G8B8, D3DPOOL_DEFAULT, D3DX_FILTER_LINEAR, D3DX_FILTER_LINEAR, &HFF000000, ByVal 0, ByVal 0) | |||
| Set Texture = mD3D.CreateTextureFromFileInMemoryEx(device, Bytes(0), UBound(Bytes) + 1, Width, Height, 1, 0, D3DFMT_A8R8G8B8, D3DPOOL_MANAGED, D3DX_FILTER_LINEAR, D3DX_FILTER_LINEAR, &HFF000000, ByVal 0, ByVal 0) | |||
There was a problem hiding this comment.
Hay que primero llamar mD3D.CreateTextureFromFileInMemoryEx( ... D3DPOOL_DEFAULT)
y si eso falla llamar con mD3D.CreateTextureFromFileInMemoryEx( ... D3DPOOL_MANAGED)
There was a problem hiding this comment.
@morgolock cuál sería el razonamiento de esta sugerencia?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue relacionado: ao-org/argentum-online-server#578.
En los logs podemos ver que uno de los problemas es que se intenta modificar el array mientras está en uso; esto es porque los bloques
Withtoman una referencia del arreglo (en este casosurfaceEntry), el cual más adelante (enRemoveLRU) estamos intentando redimensionar.Por otro lado, no hay ninguna razón* para usar
D3DPOOL_DEFAULTen lugar deD3DPOOL_MANAGED(referencia), así que lo cambié en los lugares que se estaba usando.* En el caso de las texturas. Para los vertex buffers e index buffers, como usan D3DUSAGE_DYNAMIC, no se puede.