v3: Re-export v4 hash #418
Draft
+144
−297
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
febo
commented
Oct 31, 2025
| [profile.dev.build-override] | ||
| opt-level = 1 | ||
|
|
||
| [patch.crates-io] |
There was a problem hiding this comment.
These are all solana-* dependencies from the hash crate so they will always use the repository version instead of crates.io ones.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
There was a major version of
solana-hashsince features were created so dependencies are optional and the crate was madeno_stdcompatible. Although the types between the version have not changed, the major bump makes them to be considered different.Solution
Follow the semver trick and re-export the v4 type on v3, so they will be considered the same type.