pubkey: Make no-std compatible by enabling atomic with std #388
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#### Problem The pubkey crate doesn't compile for no-std environments because the atomic feature is always enabled on address. This is an alternative to anza-xyz#302. #### Summary of changes Add the "atomic" feature to the "std" feature in pubkey, and enable "std" as appropriate for certain tests. We could do the same with "decode", but since it isn't required, I'm inclined to make a minimal change. People can switch to address for more control.
vadorovsky
approved these changes
Oct 20, 2025
Member
vadorovsky
left a comment
vadorovsky
left a comment
There was a problem hiding this comment.
Awesome, much cleaner than my solution!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The pubkey crate doesn't compile for no-std environments because the atomic feature is always enabled on address.
This is an alternative to #302.
Summary of changes
Add the "atomic" feature to the "std" feature in pubkey, and enable "std" as appropriate for certain tests.
We could do the same with "decode", but since it isn't required, I'm inclined to make a minimal change. People can switch to address for more control.