Use Address instead of Pubkey in more places #346
Conversation
|
If this PR represents a change to the sysvar layout, please open a follow-up PR to update the JavaScript client |
febo
left a comment
febo
left a comment
There was a problem hiding this comment.
Looks really good! Noticed that some of the crates are still referencing solana_pubkey – I guess they will be eventually updated in a separate PR.
|
Yeah exactly, this change is the base of what's required to make pubkey no-std without breaking things. We'll have to make more changes later |
#### Problem The sdk repo still uses Pubkey mostly, which makes it tougher to make more of the SDK no-std. #### Summary of changes Use Address in more places, to avoid adding the std feature on solana-pubkey as much as possible.
|
If this PR represents a change to the sysvar layout, please open a follow-up PR to update the JavaScript client |
2 participants
Problem
The sdk repo still uses Pubkey mostly, which makes it tougher to make more of the SDK no-std.
Summary of changes
Use Address in more places, to avoid adding the std feature on solana-pubkey as much as possible.
This will help #302 land with minimal additional changes.