address: Add copy feature #343
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Looks great! We just need to have a firm idea of how to release it. I think it's the perfect time for the semver trick |
febo
commented
Oct 2, 2025
| } | ||
|
|
||
| pub const fn to_bytes(self) -> [u8; 32] { | ||
| pub const fn to_bytes(&self) -> [u8; 32] { |
Contributor
Author
There was a problem hiding this comment.
Taking a reference avoids breaking code that relied on address being Copy.
joncinque
reviewed
Oct 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
As described in #342 , deriving
Copyby default makes it easier to create more copies than expected, in particular when writing on-chain programs.Solution
Add a feature
"copy"so the derive is opt-in.Closes #342