Skip to content

Avoid doing two simulations per transaction execution #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
lorisleiva merged 1 commit into from
Jan 28, 2026
Merged

Avoid doing two simulations per transaction execution #55

lorisleiva merged 1 commit into from
Jan 28, 2026
+40 −1

Conversation

@lorisleiva
Copy link
Member

@lorisleiva lorisleiva commented Jan 28, 2026 •
edited
Loading

This PR adds the skipPreflight: true to the sendAndConfirmTransaction call since we are already performing a simulation in the default RPC TransactionPlanExecutor in order to estimate the required amount of Compute Unit limit to set.

@lorisleiva Graphite App
Copy link
Member Author

lorisleiva commented Jan 28, 2026 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

@lorisleiva lorisleiva mentioned this pull request Jan 28, 2026
Merged
@lorisleiva lorisleiva marked this pull request as ready for review January 28, 2026 14:35
@lorisleiva lorisleiva force-pushed the 01-28-avoid_doing_two_simulations_per_transaction_execution branch 2 times, most recently from 464452e to e983533 Compare January 28, 2026 14:36
@lorisleiva lorisleiva force-pushed the 01-28-use_unwrapsimulationerror_in_default_transaction_plan_executors branch from 025e8a4 to 5d2f136 Compare January 28, 2026 14:36
@lorisleiva lorisleiva mentioned this pull request Jan 28, 2026
Merged
mcintyre94
mcintyre94 approved these changes Jan 28, 2026
View reviewed changes
Copy link
Member

@mcintyre94 mcintyre94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, agree with this!

@lorisleiva lorisleiva mentioned this pull request Jan 28, 2026
Merged
@lorisleiva Graphite App
Copy link
Member Author

lorisleiva commented Jan 28, 2026 •
edited
Loading

Merge activity

  • Jan 28, 8:26 PM UTC: A user started a stack merge that includes this pull request via Graphite.
  • Jan 28, 8:27 PM UTC: Graphite rebased this pull request as part of a merge.
  • Jan 28, 8:28 PM UTC: @lorisleiva merged this pull request with Graphite.

@lorisleiva lorisleiva changed the base branch from 01-28-use_unwrapsimulationerror_in_default_transaction_plan_executors to graphite-base/55 January 28, 2026 20:26
@lorisleiva lorisleiva changed the base branch from graphite-base/55 to main January 28, 2026 20:26
@lorisleiva lorisleiva force-pushed the 01-28-avoid_doing_two_simulations_per_transaction_execution branch from e983533 to 52febbf Compare January 28, 2026 20:27
@lorisleiva lorisleiva merged commit 0b1009f into main Jan 28, 2026
5 checks passed
@github-actions github-actions bot mentioned this pull request Jan 28, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mcintyre94 mcintyre94 mcintyre94 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@lorisleiva @mcintyre94