v1.18: sleep instead of drop when stream rate exceeded limit; (backport of #939) #990
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
* sleep instead of drop when stream rate exceeded limit; Consider connection count of staked nodes when calculating allowed PPS remove rtt from throttle_duration calculation removed connection count in StreamerCounter -- we do not need it at this point * remove connection count related changes -- they are unrelated to this PR * revert unintended changes (cherry picked from commit 137a982)
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## v1.18 #990 +/- ##
=========================================
- Coverage 81.5% 81.5% -0.1%
=========================================
Files 827 827
Lines 224853 224860 +7
=========================================
+ Hits 183467 183471 +4
- Misses 41386 41389 +3 |
pgarg66
approved these changes
Apr 23, 2024
anwayde
pushed a commit
to firedancer-io/agave
that referenced
this pull request
Jul 23, 2024
…rt of anza-xyz#939) (anza-xyz#990) sleep instead of drop when stream rate exceeded limit; (anza-xyz#939) * sleep instead of drop when stream rate exceeded limit; Consider connection count of staked nodes when calculating allowed PPS remove rtt from throttle_duration calculation removed connection count in StreamerCounter -- we do not need it at this point * remove connection count related changes -- they are unrelated to this PR * revert unintended changes (cherry picked from commit 137a982) Co-authored-by: Lijun Wang <83639177+lijunwangs@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Currently we are dropping the stream right away when the stream rate limit is being exceeded. The problem is the client can retry right away. In addition, the stream might have been received and can be used, dropping it waste resources.
Summary of Changes
Change to sleep instead of drop. Thanks to @alessandrod -- we sleep based on the estimated time to elapse to appease the rate limit and consider the RTT for the connection.
Fixes #
This is an automatic backport of pull request #939 done by [Mergify](https://mergify.com).