Refactor - Remove program_accounts_map from account_loader
#768
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lichtso
force-pushed
the
refactor/remove_program_accounts_map
branch
from
2593dd4
to
0650426
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #768 +/- ##
=======================================
Coverage 81.9% 81.9%
=======================================
Files 851 851
Lines 231209 231246 +37
=======================================
+ Hits 189495 189533 +38
+ Misses 41714 41713 -1 |
Lichtso
force-pushed
the
refactor/remove_program_accounts_map
branch
from
0650426
to
2a9e531
Compare
Lichtso
commented
Apr 15, 2024
buffalojoec
previously approved these changes
Apr 15, 2024
There was a problem hiding this comment.
You've asked me only to look at the second commit, so I did not review the first or #606.
Lgtm!
Lichtso
force-pushed
the
refactor/remove_program_accounts_map
branch
2 times, most recently
from
1e6ab0b
to
61ed3c4
Compare
…ata_from_program(), load_transaction_accounts() and load_accounts().
Lichtso
force-pushed
the
refactor/remove_program_accounts_map
branch
from
61ed3c4
to
2a4adcc
Compare
buffalojoec
approved these changes
Apr 17, 2024
michaelschem
pushed a commit
to michaelschem/agave
that referenced
this pull request
Apr 20, 2024
…z#768) Removes program_accounts / program_accounts_map from account_shared_data_from_program(), load_transaction_accounts() and load_accounts().
Lichtso
added a commit
that referenced
this pull request
Nov 7, 2024
Lichtso
added a commit
that referenced
this pull request
Nov 8, 2024
Lichtso
added a commit
that referenced
this pull request
Nov 8, 2024
Revert - #879 and #768 (#3521) * Revert "Cleanup - Removes the owner form the result of `filter_executable_program_accounts()` (#879)" This reverts commit 5fe30cb. * Revert "Refactor - Remove `program_accounts_map` from account_loader (#768)" This reverts commit e7617a1. (cherry picked from commit 57bdb8e) Co-authored-by: Alexander Meißner <AlexanderMeissner@gmx.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
program_accounts_mapis currently collected in theTransactionBatchProcessorand then wired all the way through account_loader.rs untilaccount_shared_data_from_program()where it is actually not needed because we can just useloaded_program.account_owner()instead.Summary of Changes
Removes
program_accounts_mapfrom account_loader.rs